feat: add support for New Architecture #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Aug 8, 2024
android/src/main/java/com/rncamerakit/events/OrientationChangeEvent.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/rncamerakit/events/PictureTakenEvent.kt
Outdated
Show resolved
Hide resolved
|
Hello, we need this update. Can you merge if is ok? please |
scarlac
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
@WoLewicki Thank you so much for this work!
I will merge the PR, as I was able to verify that it doesn't break iOS by default.
However, when I enable the new arch (RCT_NEW_ARCH_ENABLED=1 bundle exec pod install) then it does not compile for me. Some kind of missing spec header file.
I will happily review a follow-up PR if I cannot find the time to resolve this myself.
I think it's also prudent to upgrade the example project to the latest react native version, so we are getting the best codegen available.
|
I'll take a look at it when I have some free time, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adding New Architecture support to the library 🎉
We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:
or you just want to ask any questions, hit us up on [email protected]
How did you test this change?
Enable new architecture in
exampleapp and see that everything works correctly.