Add namespace required by newer Gradle version #632
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing to update the example app to a newer ReactNative/Gradle version (for #589), I noticed Gradle requires a namespace to be defined.
Updating the example app will be done in another PR as it requires more testing, but adding the namespace could unblock some that are using it with a newer Gradle versions
There is a warning saying we can remove it from
AndroidManifest.xml
, but I wonder if that could break for users having a very old stackHow did you test this change?
The example app runs, shouldn't have any impact on the logic