Fix #614. "onError" method needs to be declared #630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the error
Unsupported top level event type "onError" dispatched, js engine: hermes
, raised by #614When Android can't access the camera, it throws an error.
On v13 we were logging the error. On v14 we are forwarding it to the app
73bd920
While doing it, we forgot to declare the method. Hence hermes raises an error for method unknown.
Fix
Declare the method "onError"
How did you test this change?
On an emulator without camera, it doesn't raise the error anymore.
And if "onError" is added on the application
It does forward it.