Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reflection] Major rework for much faster compile-times #179

Merged

Conversation

alexkaratarakis
Copy link
Collaborator

@alexkaratarakis alexkaratarakis commented Dec 13, 2024

Much faster and does not run out of memory for structs of around 1000 members.

@alexkaratarakis alexkaratarakis force-pushed the reflection_without_tuples branch 2 times, most recently from 82eb1f2 to 2fd3b04 Compare December 23, 2024 23:40
@alexkaratarakis alexkaratarakis force-pushed the reflection_without_tuples branch from 2fd3b04 to 25af060 Compare January 3, 2025 22:54
In preparation for reworking reflection for faster compile-times
Now practical due to the reworked reflection
Mapping a struct to a tuple can be very slow for high enough sizes,
which the practical reason it was limited to <=400 fields.

The functionality can be serviced by the previously introduced
struct_decomposition
@alexkaratarakis alexkaratarakis force-pushed the reflection_without_tuples branch from 25af060 to bac4457 Compare January 3, 2025 23:00
@alexkaratarakis alexkaratarakis merged commit bac4457 into teslamotors:main Jan 8, 2025
5 checks passed
@alexkaratarakis alexkaratarakis deleted the reflection_without_tuples branch January 8, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant