Fix HTTP panic caused by nil pointer exception from a missing remote hash #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyates
approved these changes
Aug 25, 2021
|
Agree that this matches the implementation in s3 downloader. Would it be possible to add some tests around this? At the very least some documentation on the interface would be nice so we know expected behavior |
scottcrossen
force-pushed
the
slc/fix-http-panic
branch
from
f57bc88
to
463983d
Compare
|
Tests added |
|
And some docs on the downloader interface please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the original intent and is included in the s3Downloader implementation of this interface