[DO NOT MERGE] Diff view: PR #2420 current head vs PR #3130 branch point - #23
Open
terrykong wants to merge 41 commits into
Open
[DO NOT MERGE] Diff view: PR #2420 current head vs PR #3130 branch point#23terrykong wants to merge 41 commits into
terrykong wants to merge 41 commits into
Conversation
…DIA-NeMo#2983) Signed-off-by: Hollow Man <hollowman@opensuse.org>
Signed-off-by: Hollow Man <hollowman@opensuse.org>
…A-NeMo#2608) Signed-off-by: Hollow Man <hollowman@opensuse.org>
Add the TRT-LLM PyTorch backend integration needed to validate GRPO with draft-target speculative decoding, Mongo rollout logging, and weight-sync timing on AIHub. chore(trtllm): drop speculative decoding and MongoDB logging Remove the experimental speculative-decoding hooks (config, worker plumbing, spec_token_origins propagation, specdec exemplar config) and the MongoDB logger backend that were bundled with the TRT-LLM backend introduction. The TRT-LLM PyTorch backend itself is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> chore(trtllm): WIP — wire trtllm backend on top of CUDA 13 TMP commit (will amend or squash later). Layers TRT-LLM-specific wiring on top of the CUDA 13 squash from NVIDIA-NeMo#2332: - pyproject.toml: pin trtllm extra to tensorrt_llm==1.3.0rc13 - virtual_cluster.py: add PY_EXECUTABLES.TRTLLM - ray_actor_environment_registry.py: add TRTLLM_EXECUTABLE (with NEMO_RL_PY_EXECUTABLES_SYSTEM=1 fallback) - docker/Dockerfile: add SKIP_TRTLLM_BUILD arg + HPCX env exposure (cuda-compat removed — cu13.2 base image already provides it) - docs/docker.md: SKIP_TRTLLM_BUILD usage docs Known TODOs before this can be promoted: - `uv lock` likely fails: tensorrt-llm 1.3.0rc13 has no cp313 wheel. Either move trtllm to its own workspace (cp312) or relax pin. - Build + smoke test on a GB200 node not yet validated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Downgrade to Python 3.12 Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Successfully run nemorl+trtllm and verify convergence Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Add async support Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Support colocated case Cleanup Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> drop cp313 flash-attn wheel pin to unblock cp312 lock Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> drop branch-local nemo_gym changes Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Refactor Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Refactor code Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Change flash attn wheel Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Verify perf Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> Discard weights Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com> add py3.13 build infrastructure with torch 2.10 Signed-off-by: Shiki Wu <shikiw@ipp1-3010.ipp1a1.colossus.nvidia.com> Initial Async support Signed-off-by: Shiki Wu <shikiw@ipp1-3010.ipp1a1.colossus.nvidia.com> add async support for trtllm Signed-off-by: Shiki Wu <shikiw@nvidia.com>
Signed-off-by: shuyix <219646547+shuyixiong@users.noreply.github.com>
…source Signed-off-by: shuyix <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyix <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyix <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
… agentRL PR) Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyix <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
…o avoid colocated wake OOM Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: Shiki Wu <shikiw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff-viewing PR only — do not merge.
pr3130-root= 6a76269): the commit feat(trtllm): support agentic training for SWE rollout NVIDIA-NeMo/RL#3130 is rooted at (its copy of "Fix rebase conflict and Add logprobs_simple_format=True" from feat(generation): add TensorRT-LLM rollout backend NVIDIA-NeMo/RL#2420).pr2420-current-head= 2643099): the current head of feat(generation): add TensorRT-LLM rollout backend NVIDIA-NeMo/RL#2420 (shuyixiong:shuyix/trtllm).The diff shows everything PR 2420 now has that PR 3130 does not: the 5 new commits (single-source fork ref, compile-job reduction, ccache validation, rebase conflict resolution, non-colocated async recipe) plus the newer
mainbase 2420 was rebased onto.🤖 Generated with Claude Code