Skip to content

Mark windows-shell setting as deprecated - #464

Merged
terror merged 7 commits into
masterfrom
windows-shell-deprecated
Jul 17, 2026
Merged

Mark windows-shell setting as deprecated#464
terror merged 7 commits into
masterfrom
windows-shell-deprecated

Conversation

@terror

@terror terror commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Marks the windows-shell setting as deprecated (just master, casey/just#3536), surfacing deprecation diagnostics and completion metadata. The stock rename quickfix is skipped since the replacement is a pattern change ([windows] attribute on set shell), not a rename.

@codecov-commenter

codecov-commenter commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.73418% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.12%. Comparing base (eab0c1a) to head (f9497e1).

Files with missing lines Patch % Lines
src/deprecation.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   95.10%   95.12%   +0.02%     
==========================================
  Files          60       62       +2     
  Lines       13371    13449      +78     
==========================================
+ Hits        12716    12793      +77     
- Misses        655      656       +1     
Flag Coverage Δ
unit 95.12% <98.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terror
terror force-pushed the windows-shell-deprecated branch from 0d914a3 to 9140e17 Compare July 8, 2026 15:59
@terror

terror commented Jul 11, 2026

Copy link
Copy Markdown
Owner Author

How should the diagnostic behave when a file contains both the deprecated windows-shell setting and an equivalent [windows] set shell declaration? A test for that mixed configuration could ensure the server reports deprecation without offering a misleading automated edit or producing duplicate/conflicting diagnostics. It may also be worth documenting that migration requires a structural rewrite rather than a simple key rename.

You raise a good point, and I'm still a bit hesitant for this PR. Going to have to give it a bit more thought.

@terror
terror marked this pull request as draft July 11, 2026 23:39
@terror
terror force-pushed the windows-shell-deprecated branch from e28f9d9 to 8e9dc49 Compare July 11, 2026 23:56
@terror
terror changed the base branch from master to agent/setting-attributes July 11, 2026 23:56
Base automatically changed from agent/setting-attributes to master July 12, 2026 00:00
@terror
terror marked this pull request as ready for review July 17, 2026 00:43
@terror
terror force-pushed the windows-shell-deprecated branch from 14da19f to 76fbe23 Compare July 17, 2026 00:44
@terror
terror merged commit 98763d9 into master Jul 17, 2026
8 checks passed
@terror
terror deleted the windows-shell-deprecated branch July 17, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants