-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BGE-M3 Encoder #22
Conversation
Add BGE-M3 based Encoder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! I think it's mostly there, but it needs a few changes. Mostly stuff to bring it in line with the existing conventions in the package so that it doesn't need to be treated differently.
Also, can you add unit tests?
realised my review wasnt submitted (and its substantially the same as Seans) |
This looks better now Andreas. You need some unit tests though. @seanmacavaney should we align the column names for the multi-vec with the pyt_colbert?:
|
@cmacdonald I largely agree the above. But it looks like |
@andreaschari chatting with @cmacdonald, I think we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @andreaschari!
Adds BGE-M3 Encoder support and documentation.