Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epsg service #961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add epsg service #961

wants to merge 1 commit into from

Conversation

hwbllmnn
Copy link
Member

@hwbllmnn hwbllmnn commented Dec 20, 2024

Description

This adds an /epsg endpoint that can be used as an alternative to the https://epsg.io API. Example: /epsg?q=EPSG:25832. Please note that this adds a dependency to GeoTools 33-SNAPSHOT as it needs unreleased functionality to produce the proj string of the coordinate system.

Also adds an /epsg/transform endpoint that can be used to transform WKT geometries from one crs to another. Example: /epsg/transform?source=EPSG:4326&target=EPSG:25832&wkt=POINT(45%207)

Related issues or pull requests

See https://github.com/terrestris/react-util/blob/main/src/Hooks/useProjFromEpsgIO/useProjFromEpsgIO.ts

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 377 files.

Valid Invalid Ignored Fixed
313 2 62 0
Click to see the invalid file list
  • shogun-boot/src/main/java/de/terrestris/shogun/boot/controller/ProjectionController.java
  • shogun-boot/src/main/java/de/terrestris/shogun/boot/service/ProjectionService.java
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@marcjansen
Copy link
Member

Looks great, can you add some tests maybe?

@hwbllmnn hwbllmnn force-pushed the add-epsg-service branch 3 times, most recently from 6bc8c4c to 3770f62 Compare December 20, 2024 10:25
@hwbllmnn
Copy link
Member Author

Looks great, can you add some tests maybe?

Done, I've also added another endpoint to transform WKT geometries.

Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome @hwbllmnn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants