Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore events for realms other then SHOGun #906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KaiVolland
Copy link
Member

@KaiVolland KaiVolland commented Aug 12, 2024

Description

This checks for the realm id when handling keycloak events. If realm name does not equal (ignore case) "shogun" the event is not handled.

@dnlkoch Do we want to have this configurable?

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@dnlkoch
Copy link
Member

dnlkoch commented Aug 15, 2024

Yes, I would recommend to make use of the existing configuration option for the realm here as well.

@dnlkoch
Copy link
Member

dnlkoch commented Dec 23, 2024

This might be obsolete when using the latest version of the keycloak-event-listener-shogun now (see PR 11). Could you check if this fixes your issues @KaiVolland?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants