-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple/example shape and metadata solr importers #577
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 398 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
284 | 2 | 112 | 0 |
Click to see the invalid file list
- shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/MetadataImporter.java
- shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/ShapeImporter.java
shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/MetadataImporter.java
Outdated
Show resolved
Hide resolved
shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/ShapeImporter.java
Outdated
Show resolved
Hide resolved
Add solr note to README Fix license headers
WKTWriter2 wkt = new WKTWriter2(); | ||
doc.addField("id", String.format("%s_%s", prefix, feature.getID())); | ||
doc.addField("category", category); | ||
doc.addField("title", feature.getProperty("EBENE").getValue() + " " + feature.getProperty("NAME").getValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc.addField("title", feature.getProperty("EBENE").getValue() + " " + feature.getProperty("NAME").getValue()); |
Maybe remove this line as we found out that these fields are specific fields from another project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one remark to a line that contains specific properties which only exist in general.
Description
This adds two simple helper classes that import features from a shape file and metadata documents from a CSW into a solr search index.
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn test
locally).