Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple/example shape and metadata solr importers #577

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hwbllmnn
Copy link
Member

Description

This adds two simple helper classes that import features from a shape file and metadata documents from a CSW into a solr search index.

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 398 files.

Valid Invalid Ignored Fixed
284 2 112 0
Click to see the invalid file list
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/MetadataImporter.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/ShapeImporter.java

Add solr note to README

Fix license headers
WKTWriter2 wkt = new WKTWriter2();
doc.addField("id", String.format("%s_%s", prefix, feature.getID()));
doc.addField("category", category);
doc.addField("title", feature.getProperty("EBENE").getValue() + " " + feature.getProperty("NAME").getValue());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doc.addField("title", feature.getProperty("EBENE").getValue() + " " + feature.getProperty("NAME").getValue());

Maybe remove this line as we found out that these fields are specific fields from another project?

Copy link
Member

@mholthausen mholthausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one remark to a line that contains specific properties which only exist in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants