make sure only the most recent request data is used #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
reviewed
May 4, 2018
src/Field/WfsSearch/WfsSearch.jsx
Outdated
| this.setState({ | ||
| fetching: true, | ||
| latestRequestTime: fetchTime.getTime() | ||
| }); |
There was a problem hiding this comment.
Not sure, if it may be relevant here, but updating the state might be asynchronous so the check in onFetchSuccess() might fail in succession. It might be worthwhile to check to call the fetch in the callback from setState().
There was a problem hiding this comment.
You're right, of course. Fixed this and the failing test in 0ff62fc.
|
Very nice. I think it would additionally make sense to debounce the sending of the request while typing with the suggested smallish timeout. 100 ms probably? Only do thois if it can be done without hassle. |
KaiVolland
approved these changes
May 4, 2018
|
I added a configurable timeout in 29d6b60, with a default of 300ms (that felt right to me, might be different for others). |
hblitza
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Update dependencies * Cleanup import list * Readd commented line * Update src/GeometryUtil/GeometryUtil.js Co-authored-by: Marc Jansen <[email protected]> Co-authored-by: Marc Jansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIX
Description:
This fixes issue #621 , making sure only the most recent search request data is used. Thanks @KaiVolland !
@terrestris/devs Please review.