Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass type prop to Button #4061

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Pass type prop to Button #4061

merged 1 commit into from
Oct 17, 2024

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Oct 17, 2024

Description

Now the type prop is passed through to the Button component.

Please review @terrestris/devs.

Related issues or pull requests

--

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm run check locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@dnlkoch
Copy link
Member Author

dnlkoch commented Oct 17, 2024

Thanks for the review!

@dnlkoch dnlkoch merged commit 36e433a into main Oct 17, 2024
2 checks passed
@dnlkoch
Copy link
Member Author

dnlkoch commented Oct 17, 2024

🎉 This PR is included in version 25.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants