Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Userchip component #4

Merged
merged 6 commits into from
Sep 5, 2017
Merged

Add Userchip component #4

merged 6 commits into from
Sep 5, 2017

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Sep 1, 2017

This PR adds an user chip component to react-geo, its tests and an example.

#map {
height: 256px;
margin: 1em;
.userchip {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to more generic class name or move to example code itself.

Copy link
Member Author

@ahennr ahennr Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed style definition in template.

@ahennr ahennr force-pushed the userchip branch 2 times, most recently from b1176ed to 67e322a Compare September 1, 2017 14:52
@ahennr ahennr changed the title [WIP] Add Userchip component Add Userchip component Sep 1, 2017
@terrestris terrestris deleted a comment from coveralls Sep 1, 2017
@terrestris terrestris deleted a comment from coveralls Sep 1, 2017
@terrestris terrestris deleted a comment from coveralls Sep 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.4%) to 94.186% when pulling 9d28d55 on ahennr:userchip into 2f8ad1f on terrestris:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.4%) to 94.186% when pulling 7487284 on ahennr:userchip into 29ba4ce on terrestris:master.

@KaiVolland KaiVolland merged commit 1d465d0 into terrestris:master Sep 5, 2017
@KaiVolland KaiVolland mentioned this pull request Nov 30, 2017
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants