Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify LayerTree and more useCallback #3861

Merged
merged 1 commit into from
May 28, 2024

Conversation

simonseyock
Copy link
Member

Description

This simplifies the LayerTree by removing listeners in the useEffect cleanup functions.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@simonseyock simonseyock merged commit ed10fca into main May 28, 2024
2 checks passed
@simonseyock simonseyock deleted the simplify-layer-tree branch May 28, 2024 07:48
@dnlkoch
Copy link
Member

dnlkoch commented May 28, 2024

🎉 This PR is included in version 24.0.0-main.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dnlkoch
Copy link
Member

dnlkoch commented Jun 12, 2024

🎉 This PR is included in version 24.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants