-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FeatureGrid
and AgFeatureGrid
to a function component
#3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58a731e
to
b6cca5c
Compare
b6cca5c
to
5c6c0f5
Compare
BREAKING CHANGE: share common grid props among all grids
BREAKING CHANGE: Bump aggrid to version 31.1 and bump required OpenLayers dependency to v9 in package.json
BREAKING CHANGE: remove prop types dependency
FeatureGrid
to a function componentFeatureGrid
and AgFeatureGrid
to a function component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the
FeatureGrid
and theAgFeatureGrid
to function components (and makes use of the shared hookuseOlLayer
). In addition, common grid properties and variables are extracted to acommonGrid.ts
file.Breaking changes:
columnDefs
got removed, use defaultcolumns
instead (inFeatureGrid
)Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
BSD-2-Clause.
npm test
locally).