-
Notifications
You must be signed in to change notification settings - Fork 19
add option to pass tags as parameter to apply to aws resources #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vamsinm
wants to merge
4
commits into
terraform-redhat:main
Choose a base branch
from
StateFarmIns:tag-parameter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
86be15d
add option to pass tags as parameter to apply to aws resources
vamsinm 3e36a7c
updated aws->AWS and added example code and inputs table to all read …
vamsinm 1aa0104
fixed aws in operator_roles_creation readme
vamsinm 43eb2c1
updates sample usage readme files in sub moudles with tags example
vamsinm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,36 @@ | ||
| variable account_role_prefix { | ||
| type = string | ||
| variable "account_role_prefix" { | ||
| type = string | ||
| } | ||
|
|
||
| variable account_role_properties { | ||
| description = "Account IAM role properties" | ||
| type = object({ | ||
| role_name = string | ||
| role_type = string | ||
| principal = string | ||
| policy_details = string | ||
| }) | ||
| variable "account_role_properties" { | ||
| description = "Account IAM role properties" | ||
| type = object({ | ||
| role_name = string | ||
| role_type = string | ||
| principal = string | ||
| policy_details = string | ||
| }) | ||
| } | ||
|
|
||
| variable instance_account_role_properties { | ||
| description = "Account IAM role properties" | ||
| type = object({ | ||
| role_name = string | ||
| role_type = string | ||
| policy_details = string | ||
| }) | ||
| variable "instance_account_role_properties" { | ||
| description = "Account IAM role properties" | ||
| type = object({ | ||
| role_name = string | ||
| role_type = string | ||
| policy_details = string | ||
| }) | ||
| } | ||
|
|
||
| variable rosa_openshift_version { | ||
| type = string | ||
| default = "4.12" | ||
| variable "rosa_openshift_version" { | ||
| type = string | ||
| default = "4.12" | ||
| } | ||
| variable "account_id" { | ||
| type = string | ||
| } | ||
|
|
||
| variable "tags" { | ||
| description = "List of aws resource tags to apply." | ||
vamsinm marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| type = map(string) | ||
| default = null | ||
| } | ||
| variable account_id { | ||
| type = string | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 7 additions & 7 deletions
14
account_roles_creation/operator_role_policy/operator_policy.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| resource "aws_iam_policy" "operator-policy" { | ||
| name = "${var.operator_role_policy_properties.policy_name}" | ||
| name = var.operator_role_policy_properties.policy_name | ||
| policy = var.operator_role_policy_properties.policy_details | ||
|
|
||
| tags = { | ||
| rosa_openshift_version="${var.rosa_openshift_version}" | ||
| rosa_role_prefix="${var.account_role_prefix}" | ||
| operator_namespace="${var.operator_role_policy_properties.namespace}" | ||
| operator_name="${var.operator_role_policy_properties.operator_name}" | ||
| } | ||
| tags = merge(var.tags, { | ||
| rosa_openshift_version = "${var.rosa_openshift_version}" | ||
| rosa_role_prefix = "${var.account_role_prefix}" | ||
| operator_namespace = "${var.operator_role_policy_properties.namespace}" | ||
| operator_name = "${var.operator_role_policy_properties.operator_name}" | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,24 @@ | ||
| variable account_role_prefix { | ||
| type = string | ||
| variable "account_role_prefix" { | ||
| type = string | ||
| } | ||
|
|
||
| variable operator_role_policy_properties { | ||
| description = "Account IAM role properties" | ||
| type = object({ | ||
| policy_name = string | ||
| policy_details = string | ||
| namespace = string | ||
| operator_name = string | ||
| }) | ||
| variable "operator_role_policy_properties" { | ||
| description = "Account IAM role properties" | ||
| type = object({ | ||
| policy_name = string | ||
| policy_details = string | ||
| namespace = string | ||
| operator_name = string | ||
| }) | ||
| } | ||
|
|
||
| variable rosa_openshift_version { | ||
| type = string | ||
| default = "4.12" | ||
| variable "rosa_openshift_version" { | ||
| type = string | ||
| default = "4.12" | ||
| } | ||
|
|
||
| variable "tags" { | ||
| description = "List of aws resource tags to apply." | ||
vamsinm marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| type = map(string) | ||
| default = null | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.