Remove default TTLs for vault_gcp_secret_backend #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
The default in Vault API docs are "0" which refers to the system TTL settings. The resource should not attempt to set its own defaults, which is going to be surprising for users
tyrannosaurus-becks
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Thanks @lawliet89 ! Yes, I think this looks great. I see that if it's set to 0 it'll use the system default, which makes much more sense.
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Remove default TTLs for vault_gcp_secret_backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default in Vault API docs are "" which refers to the system TTL
settings. The resource should not attempt to set its own defaults, which
is going to be surprising for users
https://www.vaultproject.io/api/system/mounts.html#enable-secrets-engine