Skip to content

Commit

Permalink
Remove default TTLs for vault_gcp_secret_backend
Browse files Browse the repository at this point in the history
The default in Vault API docs are "0" which refers to the system TTL
settings. The resource should not attempt to set its own defaults, which
is going to be surprising for users
  • Loading branch information
lawliet89 committed May 27, 2019
1 parent 0663de9 commit 94a8852
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions vault/resource_gcp_secret_backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ func gcpSecretBackendResource() *schema.Resource {
"default_lease_ttl_seconds": {
Type: schema.TypeInt,
Optional: true,
Default: "3600",
Computed: true,
Description: "Default lease duration for secrets in seconds",
},
"max_lease_ttl_seconds": {
Type: schema.TypeInt,
Optional: true,
Default: "86400",
Computed: true,
Description: "Maximum possible lease duration for secrets in seconds",
},
},
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/gcp_secret_backend.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ not begin or end with a `/`. Defaults to `gcp`.
* `description` - (Optional) A human-friendly description for this backend.

* `default_lease_ttl_seconds` - (Optional) The default TTL for credentials
issued by this backend. Defaults to '3600'.
issued by this backend. Defaults to '0'.

* `max_lease_ttl_seconds` - (Optional) The maximum TTL that can be requested
for credentials issued by this backend. Defaults to '86400'.
for credentials issued by this backend. Defaults to '0'.

## Attributes Reference

Expand Down

0 comments on commit 94a8852

Please sign in to comment.