Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New features in azurerm_storage_management_policy #11163

Merged
merged 33 commits into from
Apr 27, 2021
Merged

New features in azurerm_storage_management_policy #11163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ddc8b4c
update
Feb 1, 2021
ee671a8
update
Feb 1, 2021
761f58d
update
Feb 1, 2021
dcec0ee
fmt
Feb 1, 2021
935c988
update
Feb 2, 2021
1139b25
update
Feb 2, 2021
2810a31
update
Mar 23, 2021
b8ec965
update
Mar 23, 2021
3728889
update
Mar 24, 2021
91096c5
update
Mar 24, 2021
4ec4dfb
fmt
Mar 24, 2021
50905a6
update
Mar 24, 2021
1a29cd8
update acctest
Mar 25, 2021
d02670e
merge
Mar 26, 2021
1b81a29
update
Mar 26, 2021
af20341
update
Mar 29, 2021
e51c09a
all pass
Mar 29, 2021
6b279bd
merge
Mar 31, 2021
31afa4f
lint
Mar 31, 2021
de1b5e2
update
Apr 7, 2021
e335244
update
Apr 7, 2021
b5e6137
update
Apr 21, 2021
a6b5ca6
update
Apr 21, 2021
2682518
update
Apr 21, 2021
37ca9b7
update
Apr 21, 2021
152c668
update
Apr 21, 2021
e6fb73a
update
Apr 21, 2021
34763ef
update
Apr 21, 2021
7d47fb5
Merge branch 'master' of https://github.com/terraform-providers/terra…
Apr 21, 2021
c556bda
update
Apr 21, 2021
e52dcd5
merge
Apr 25, 2021
66e77d2
update
Apr 26, 2021
51f914a
Update website/docs/r/storage_management_policy.html.markdown
katbyte Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 55 additions & 4 deletions azurerm/internal/services/storage/storage_management_policy_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,29 @@ func dataSourceStorageManagementPolicy() *schema.Resource {
Elem: &schema.Schema{Type: schema.TypeString},
Set: schema.HashString,
},

"match_blob_index_tag": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this another "not yet in global property?"

------- Stdout: -------
=== RUN   TestAccStorageManagementPolicy_blobIndexMatch
=== PAUSE TestAccStorageManagementPolicy_blobIndexMatch
=== CONT  TestAccStorageManagementPolicy_blobIndexMatch
    testing.go:620: Step 3/6 error: Error running apply: exit status 1
        
        Error: creating Azure Storage Management Policy "/subscriptions/*******/resourceGroups/acctestRG-storage-210426173350412751/providers/Microsoft.Storage/storageAccounts/unlikely23exst2acctu9ru0": storage.ManagementPoliciesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="FeatureNotSupportedForAccount" Message="Tag based filtering is not supported for the account."
        
          on terraform_plugin_test.tf line 30, in resource "azurerm_storage_management_policy" "test":
          30: resource "azurerm_storage_management_policy" "test" {
        
--- FAIL: TestAccStorageManagementPolicy_blobIndexMatch (212.08s)
FAIL

------- Stderr: -------
2021/04/26 17:33:49 [DEBUG] not using binary driver name, it's no longer needed
2021/04/26 17:33:50 [DEBUG] not using binary driver name, it's no longer needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It is released globally. It needs enabled the feature in the subscription. https://azure.microsoft.com/en-us/blog/manage-and-find-data-with-blob-index-for-azure-storage-now-in-preview/. I've added this into the doc, here https://github.com/terraform-providers/terraform-provider-azurerm/pull/11163/files#diff-26c23fcfb7ed0a7939dcabd4959f025c9c94e7fbe5a618c5c13e90462358a09bR108

Type: schema.TypeList,
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Computed: true,
},

"operation": {
Type: schema.TypeString,
Computed: true,
},

"value": {
Type: schema.TypeString,
Computed: true,
},
},
},
},
},
},
},
Expand Down Expand Up @@ -86,13 +109,42 @@ func dataSourceStorageManagementPolicy() *schema.Resource {
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"change_tier_to_archive_after_days_since_creation": {
Type: schema.TypeInt,
Computed: true,
},
"change_tier_to_cool_after_days_since_creation": {
Type: schema.TypeInt,
Optional: true,
Computed: true,
},
"delete_after_days_since_creation_greater_than": {
Type: schema.TypeInt,
Computed: true,
},
},
},
},
"version": {
Type: schema.TypeList,
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"change_tier_to_archive_after_days_since_creation": {
Type: schema.TypeInt,
Computed: true,
},
"change_tier_to_cool_after_days_since_creation": {
Type: schema.TypeInt,
Computed: true,
},
"delete_after_days_since_creation": {
Type: schema.TypeInt,
Computed: true,
},
},
},
},
},
},
},
Expand Down Expand Up @@ -123,11 +175,10 @@ func dataSourceStorageManagementPolicyRead(d *schema.ResourceData, meta interfac
}
d.SetId(*result.ID)

if result.Policy != nil {
policy := result.Policy
if policy.Rules != nil {
if props := result.ManagementPolicyProperties; props != nil {
if policy := props.Policy; policy != nil {
if err := d.Set("rule", flattenStorageManagementPolicyRules(policy.Rules)); err != nil {
return fmt.Errorf("Error flattening `rule`: %+v", err)
return fmt.Errorf("flattening `rule`: %+v", err)
}
}
}
Expand Down
Loading