-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM and VMSS validation fixes #6639
Conversation
…r names - Adjust naming rules to meet current API behavior - Length validation for VMSS computer name prefixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manicminer! Aside from some minor comments LGTM 👍
azurerm/internal/services/compute/linux_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/resource_arm_linux_virtual_machine_scale_set.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/resource_arm_windows_virtual_machine_scale_set.go
Outdated
Show resolved
Hide resolved
Fixed, thanks for catching! |
This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.8.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Separate validation for VM/VMSS (resource) name, and linux/windows computer names
This maintains the current behavior of assuming the
computer_name
/computer_name_prefix
from the VM / VMSS name respectively. However since thename
values now have more relaxed rules, should the specifiedname
not be a validcomputer_name
/computer_name_prefix
, then the latter must also be specified. There are new tests for these cases.