-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows_virtual_machine validation assumes computer_name is not set #6494
Comments
hi @adamday2 As @njuCZ has mentioned this has been fixed in v2.8.0 - you can upgrade to this by updating the version in the Provider block (as shown below) and then running
Since this should be fixed by updating the version of the Azure Provider being used I'm going to close this issue for the moment - but please let us know if that doesn't work for you and we'll take another look. Thanks! |
Appears to be fixed now. Thank you! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Community Note
Terraform (and AzureRM Provider) Version
Terraform v0.12.21
AzureRM 2.5.0
Affected Resource(s)
azurerm_windows_virtual_machine
Terraform Configuration Files
Expected Behavior
No errors, the
name
in the portal is a valid name for the resource in the portal (there is no 15 character limit) and thecomputer_name
is a valid hostname.Actual Behavior
It appears the the validation function is unaware of whether the
name
is being used as thecomputer_name
and is applying the same rules regardless. In the case that thecomputer_name
is provided, the rules should not be checking for valid hostnames, but instead just validating that it is a valid azure resource name.https://github.com/terraform-providers/terraform-provider-azurerm/blob/18e516bd25aed3c99477208aa2486272d7214024/azurerm/internal/services/compute/windows_virtual_machine_resource.go#L55
Steps to Reproduce
terraform apply
Important Factoids
Azure Government
References
The text was updated successfully, but these errors were encountered: