Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for linux function apps #5839

Merged
merged 3 commits into from
Feb 26, 2020
Merged

fix for linux function apps #5839

merged 3 commits into from
Feb 26, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Feb 21, 2020

addresses: #3083

@ghost ghost added size/S documentation and removed size/XS labels Feb 21, 2020
@jackofallops jackofallops added this to the v2.1.0 milestone Feb 24, 2020
@jackofallops jackofallops requested review from a team and removed request for tombuildsstuff February 24, 2020 15:01
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 4532984 into master Feb 26, 2020
@jackofallops jackofallops deleted the b/function-app-linux branch February 26, 2020 21:07
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@Bessonov
Copy link

@jackofallops Great! But how it's different from the current approach described here: #5650

@jackofallops
Copy link
Member Author

Hi @Bessonov
Function Apps are something we're planning on taking another look at as the service has evolved and grown over time and, since it is controlled by the same API as Web Apps, needs some careful consideration and investigation, especially in areas that are possibly not well documented (as you mention in your issue, kind is something of a mystery!) . Specifically the change here stopped the provider from removing 'linux' portion of the kind value, which was previously reverting anything received to simply functionapp and gave the resource an awareness of OS's other than Windows (which is the default if linux is not present in the string).

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants