runner: clean Terraform source path for comparison #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TFLint is called with a relative path formatted with a leading
./
, results are empty fromFiles()
. The logs I added for the rule that reproduced this printed:Clean
is called internally byDir
, meaning the comparison was"my/module" == "./my/module"
. Cleaning both paths ensures the values are normalized for comparison.The tests methods also call
Dir
to process a map of path -> file so adding a basic test didn't actually add coverage.But I did verify that it works as expected: