Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated comments to reflect true intent of three methods #903

Merged
merged 2 commits into from
Sep 5, 2020

Conversation

ritesh-modi
Copy link
Contributor

The comments for Check function for Terraform rules - terraform_comment_syntax, terraform_required_Providers and terraform_required_version has been updated to reflect the true intent.

Please approve the pull request such that the changes for these comments are reflected and go docs provides the right messages.

Thanks,
Ritesh

@ritesh-modi
Copy link
Contributor Author

Hello,

The change done by me are related to comments. There was no code change. The linter is making the code pull request failed inspite of no changes in code. Please suggest how to incorporate the changes suggested to the code.

Thanks,
Ritesh

@ritesh-modi
Copy link
Contributor Author

Hi Again, It would be great if you could help in merging the pull request.

Thanks again,
Ritesh

@wata727 wata727 merged commit 0e21813 into terraform-linters:master Sep 5, 2020
@wata727
Copy link
Member

wata727 commented Sep 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants