terraform_required_providers: warn on provider.version #850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the required providers rule to warn when a
provider
block specifies aversion
attribute. While this does have the effect of constraining the installed provider version, users should be moving torequired_providers
because declaring a new copy of the provider is likely to have unexpected effects for child modules.New logic is:
version
, regardless of whether it also appears inrequired_providers
.This means that users moving from earlier versions with of Terraform with
provider "foo" { version = "" }
in their configurations will see two issues that share an underlying fix. While it's possible to give more targeted messaging, there's a lot of possible cases here and keeping the rule simple seemed worthwhile.Closes #839