Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: terraform_dash_in_output_name #568

Merged
merged 4 commits into from
Jan 4, 2020
Merged

Feature: terraform_dash_in_output_name #568

merged 4 commits into from
Jan 4, 2020

Conversation

osulli
Copy link
Contributor

@osulli osulli commented Dec 30, 2019

Why

  • I believe whilst the TF documentation does not cover outputs, the 'resource' best practices should also cover outputs (specifically no dashes/hyphens in output name).

Solves

@wata727
Copy link
Member

wata727 commented Jan 2, 2020

@osulli Thank you for your contribution. Looks good, but it's better to add the link to the rules documentation index.
https://github.com/terraform-linters/tflint/blob/131b9eb9897332c54d096323a1419aeb25ac3e66/docs/rules/README.md

@osulli
Copy link
Contributor Author

osulli commented Jan 3, 2020

@wata727 that's done :)

@wata727 wata727 merged commit 3af92c3 into terraform-linters:master Jan 4, 2020
@wata727
Copy link
Member

wata727 commented Jan 4, 2020

Thanks!

@wata727 wata727 added this to the v0.14.0 milestone Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osulli @wata727