Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse absolute paths in TF_DATA_DIR correctly #555

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Parse absolute paths in TF_DATA_DIR correctly #555

merged 1 commit into from
Dec 18, 2019

Conversation

madddi
Copy link
Contributor

@madddi madddi commented Dec 17, 2019

Resolves #554

I didn't see how I could add an integration test for this, though.

@madddi madddi mentioned this pull request Dec 17, 2019
Merged
@wata727 wata727 merged commit 00f529a into terraform-linters:master Dec 18, 2019
@wata727
Copy link
Member

wata727 commented Dec 18, 2019

Thank you!

I didn't see how I could add an integration test for this, though.

Yeah, I think it's difficult to write tests that handle such absolute paths. Ignore it here.

@madddi madddi deleted the issue-554-absolute-tf_data_dir branch December 18, 2019 14:04
@wata727 wata727 mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TF_DATA_DIR containing absolute path is parsed as relative path
2 participants
@madddi @wata727