Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HCL 2.0 in the HCL repository #474

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Switch to HCL 2.0 in the HCL repository #474

merged 2 commits into from
Oct 9, 2019

Conversation

explodingcamera
Copy link
Contributor

Related to hashicorp/terraform#22982 .
This was also mostly just finding and replacing, however I also updated the link in the docs and updated terraform to a newer version which also switched to the new hcl repo. Closes #473.

Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super fast! It looks pretty good, but I left some comments.

github.com/hashicorp/hcl2 v0.0.0-20190821123243-0c888d1241f6
github.com/hashicorp/logutils v1.0.0
github.com/hashicorp/terraform v0.12.9
github.com/hashicorp/terraform v0.12.10-0.20191002221021-39e609d5fd70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to keep this version as 0.12.9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashicorp/terraform@39e609d They switched to the new repo in this commit and some types break without these changes.

go.mod Outdated Show resolved Hide resolved
@wata727 wata727 merged commit de30fdf into terraform-linters:master Oct 9, 2019
@wata727
Copy link
Member

wata727 commented Oct 9, 2019

Thanks @explodingcamera!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Switch to hcl v2 from hcl2
2 participants