-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3 checks for AWS Launch Configuration #318
Conversation
Fixes Issue terraform-linters#253 - adds rules checking in Launch Configuration: - used ami - instance type - instance profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM.
I left some comments, but these do not block getting to merge.
// NewAwsLaunchConfigurationInvalidIAMProfileRule returns new rule with default attributes | ||
func NewAwsLaunchConfigurationInvalidIAMProfileRule() *AwsLaunchConfigurationInvalidIAMProfileRule { | ||
return &AwsLaunchConfigurationInvalidIAMProfileRule{ | ||
resourceType: "aws_launch_configuration", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpicks] It seems that the indentation is broken. It might be better to run gofmt
when saving Go files 🙃
It is even better if the following documentation updates are included. |
Thanks for your feedback and comments, fixed indentation and update documentation with my new rules. |
Great work @krzyzakp! Thanks again! |
Fixes #253
Adds rules checking in Launch Configuration:
Tested on current release, hope that's fair enough to be merged for next release.