Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation checking #189

Merged
merged 2 commits into from
May 18, 2018
Merged

Fix interpolation checking #189

merged 2 commits into from
May 18, 2018

Conversation

wata727
Copy link
Member

@wata727 wata727 commented May 6, 2018

Fixes #170
Fixes #187

Modify the validation logic of expressions that TFLint can evaluate. Until now, it had been judge the expression is evaluable if contains var or terraform syntax. (Even if it contains an unevaluable function such as replace)

These changes makes it strictly perform this check to avoid errors. I considered incorporating Terraform's build-in functions, but the vendoring type problem disturbs me... Built-in functions will become available after refactoring assuming HCL2.

@wata727 wata727 merged commit 55b2043 into master May 18, 2018
@wata727 wata727 deleted the improve_interpolation branch May 18, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant