plugin: Handle sensitive values on the plugin side #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
handle_sensitive_in_plugin
branch
2 times, most recently
from
a56f91b
to
056532a
Compare
wata727
force-pushed
the
handle_sensitive_in_plugin
branch
from
056532a
to
68415f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also terraform-linters/tflint-plugin-sdk#239
See also #1700
For similar reasons as #1700, values marked sensitive were not sent to plugins. In particular, there is a technical difficulty that marked values cannot simply be serialized.
https://github.com/terraform-linters/tflint/blob/v0.45.0/plugin/server.go#L128-L137
https://github.com/zclconf/go-cty/blob/v1.13.0/cty/msgpack/marshal.go#L46-L48
https://github.com/zclconf/go-cty/blob/v1.13.0/docs/marks.md#marks-under-serialization
But given that
EvaluateExpris an endpoint that returns acty.Value, it's preferable to handle this case on the plugin side.This PR changes to skip sensitive value handling when the plugin's SDK is v0.16+. This is an internal change and has no end-user impact.