Move block expanding to under the terraform package #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
refactor_block_expanding
branch
from
2816e44 to
41a02e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1510, move the remaining evaluation logic into the terraform package. This PR will completely remove runner_eval.go.
Previously, runner was responsible for checking whether resources/modules are unevaluated such as
count = 0orfor_each = [], but moved the logic around evaluation to theterraform.Evaluatorby expanding blocks when retrieving content.This is also a preparation for #1139. Currently
expandBlocksjust checks if count/for_each is 0 or empty, but in the future we could changehclext.BodyContentaccordingly.ToDo