Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer --only option over other rules config #1516

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Sep 15, 2022

Fixes #1513
See terraform-linters/tflint-plugin-sdk#198
See terraform-linters/tflint-ruleset-terraform#26

This PR fixes a bug where preset rules are not ignored even when --only option is set.

TODO

  • Add unit tests
  • Add integration tests
  • Add documentation about rules priority

@wata727 wata727 force-pushed the prefer_only_option_over_others branch 2 times, most recently from 29d6943 to d44d3c5 Compare September 17, 2022 12:34
@wata727 wata727 force-pushed the prefer_only_option_over_others branch from d44d3c5 to e5a5fef Compare September 17, 2022 13:17
@wata727 wata727 marked this pull request as ready for review September 17, 2022 13:20
@wata727 wata727 merged commit 3922522 into master Sep 17, 2022
@wata727 wata727 deleted the prefer_only_option_over_others branch September 17, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tflint 0.40.0 ignores --only options for built in terraform module
1 participant