cmd: Change exit status

[wata727]

Fixes #528

Change the exit status to what I originally intended.

Before:

• 0: No issues found
• 2: Errors occurred
• 3: No errors occurred, but issues found

After:

• 0: No issues found
• 1: Errors occurred
• 2: No errors occurred, but issues found

This is clearly a breaking change, but due to its natural behavior, it may be worth accepting.

[bendrucker]

Seems like the original submission in #528 is focused on setting the exit code based on the issue with the highest severity level. I don't see that as a particularly compelling feature, FWIW.

I'm 👍 for this, few users depend on specific non-zero exit codes anyway. You could hang on to it for a bit and release it with other breaking changes.

[bendrucker]

Spotted something related to this:

https://golangci-lint.run/usage/configuration/

golangci-lint has an --issues-exit-code flag which defaults to 1. It's been in there for multiple years. Not really sure making this configurable is warranted but it did make me think of this discussion.

[wata727]

Interesting. I'm not sure why golangci-lint offers this as a configurable option, but at least in my opinion, it doesn't seem necessary to do that. I can't find any problems that cannot be solved unless they can be configurable.