install: support arm64 arch #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
commented
Aug 15, 2021
| @@ -41,7 +43,7 @@ else | |||
| fi | |||
|
|
|||
| echo "Downloading TFLint $version" | |||
| curl -L -o /tmp/tflint.zip "https://github.com/terraform-linters/tflint/releases/download/${version}/tflint_${os}.zip" | |||
| curl --fail --silent -L -o /tmp/tflint.zip "https://github.com/terraform-linters/tflint/releases/download/${version}/tflint_${os}.zip" | |||
There was a problem hiding this comment.
I added --fail because now it'd silently proceed, even when met with 404 (the subsequent unzip would fail instead). Also added --silent to reduce some noise. This both seems to be in line with other curl calls in this script. I included this in this PR because it's closely related to identifying which distribution to download
williamboman
added a commit
to williamboman/tflint
that referenced
this pull request
Aug 15, 2021
* upstream/master: install: support arm64 arch (terraform-linters#1185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.