install: allow passing $TFLINT_INSTALL_PATH
#1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on windows, this file was moved powershell rm seems to ignore missing by default
| $SUDO install -b -c -v /tmp/tflint /usr/local/bin/ | ||
|
|
||
| $SUDO mkdir -p "$dest" | ||
| $SUDO install -b -c -v /tmp/tflint "$dest" |
There was a problem hiding this comment.
I think it'd be neat to also control whether it should be installed as root or not. My use case is having a fully non-interactive, isolated (as in, installs to a custom path and doesn't tamper with anything system-wide/global), installation process. Wdyt?
# ¯\_(ツ)_/¯
TFLINT_INSTALL_NO_ROOT=1
TFLINT_INSTALL_NO_SUDO=1
TFLINT_INSTALL_SKIP_SUDO=1There was a problem hiding this comment.
I opened #1184 with my suggestions, thanks for looking into this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports a custom install path,
$TFLINT_INSTALL_PATH, with the previous path as the default.Fixes #1179