Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides module #118

Merged
merged 7 commits into from
Jul 8, 2017
Merged

Overrides module #118

merged 7 commits into from
Jul 8, 2017

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Jun 24, 2017

Fix #86

ToDo

  • Introduce shcema.Module
  • Add test
  • Rewrite terraform_module_pinned_source

package schema

import (
"crypto/md5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [gas] Use of weak cryptographic primitive,HIGH,HIGH

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

md5 is not used for encryption.

}
case "module":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "module" found in: detector.go:213:7 detector.go:282:7

})
}
}
case "module":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "module" found in: test_helper.go:82:7 detector.go:282:7

for _, template := range d.Schema {
targets += len(template.FindResources(target))
}
case "module":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "module" found in: test_helper.go:82:7 detector.go:213:7

reflect.ValueOf(issues),
})
switch reflect.Indirect(detector).FieldByName("TargetType").String() {
case "resource":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "resource" found in: detector.go:203:7 detector.go:278:7

reflect.ValueOf(issues),
})
switch reflect.Indirect(detector).FieldByName("TargetType").String() {
case "resource":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "resource" found in: test_helper.go:72:7 detector.go:278:7

targetResources += len(template.Node.(*ast.ObjectList).Filter("resource", target).Items)
targets := 0
switch targetType {
case "resource":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "resource" found in: test_helper.go:72:7 detector.go:203:7

@wata727 wata727 changed the title [WIP] Overrides module Overrides module Jul 2, 2017
reflect.ValueOf(issues),
})
switch reflect.Indirect(detector).FieldByName("TargetType").String() {
case "resource":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "resource" found in: detector.go:227:7 test_helper.go:71:7

targetResources += len(template.Node.(*ast.ObjectList).Filter("resource", target).Items)
targets := 0
switch targetType {
case "resource":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "resource" found in: detector.go:152:7 test_helper.go:71:7

reflect.ValueOf(issues),
})
switch reflect.Indirect(detector).FieldByName("TargetType").String() {
case "resource":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "resource" found in: detector.go:152:7 detector.go:227:7

})
}
}
case "module":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "module" found in: detector.go:231:7 test_helper.go:81:7

for _, template := range d.Schema {
targets += len(template.FindResources(target))
}
case "module":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "module" found in: detector.go:162:7 test_helper.go:81:7

}
case "module":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gometalinter]

  • [goconst] 2 other occurrence(s) of "module" found in: detector.go:162:7 detector.go:231:7

@wata727 wata727 merged commit 1f5b497 into master Jul 8, 2017
@wata727 wata727 deleted the overrides_module branch July 8, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant