Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: Deprecate bundled plugins #1160

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Jul 11, 2021

For historical reasons, the "aws" plugin was available even if you didn't install the plugin, unlike other plugins. It is called "bundled plugins".

This PR will display a deprecation warning to end support for bundled plugins. The warning will be displayed if the following conditions are met:

  • tflint-ruleset-aws was not installed
  • Terraform configurations have declarations of aws resources (such as aws_instance)

This warning is output to stderr at runtime, etc. in the following format:

$ tflint
WARNING: The plugin `aws` is not explicitly enabled. The bundled plugin will be enabled instead, but it is deprecated and will be removed in a future version. Please see https://github.com/terraform-linters/tflint/pull/1159 for details.
1 issue(s) found:

Error: "invalid" is an invalid value as instance_type (aws_instance_invalid_type)

  on template.tf line 21:
  21:   instance_type = "invalid"

You must explicitly install tflint-ruleset-aws to get rid of this warning. Add the following declaration to .tflint.hcl and install it with tflint --init.

plugin "aws" {
    enabled = true
    version = "0.5.0"
    source  = "github.com/terraform-linters/tflint-ruleset-aws"
}
$ tflint --init
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.5.0)

We will proceed step by step to end support for the bundled plugin. Please let us know if you have any operational issues at the end of support. Thank you.

@ewikum

This comment was marked as off-topic.

sskalnik added a commit to sskalnik/quest that referenced this pull request Feb 18, 2022
… Ensure 100% compliance with both tflint and tfsec.
@aidanmelen

This comment was marked as off-topic.

@terraform-linters terraform-linters locked as off-topic and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants