Call ApplyConfig before ValidateRules #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on a plugin which generates a list of rules dynamically, based on its config: https://github.com/richardTowers/tflint-ruleset-workspaces/ At the moment, it's not possible to refer to config in RuleNames because that gets called before ApplyConfig. As a workaround, I've made my plugin return the empty list for RuleNames: https://github.com/richardTowers/tflint-ruleset-workspaces/blob/master/ruleset.go#L28 Naïvely, it looks like making the ApplyConfig a bit earlier would fix this. The tests pass, but I'm not sure if this will have unintended consequences. Careful review would be much appreciated!
wata727
approved these changes
Jan 24, 2021
This was referenced Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a plugin which generates a list of rules dynamically,
based on its config:
https://github.com/richardTowers/tflint-ruleset-workspaces/
At the moment, it's not possible to refer to config in RuleNames because
that gets called before ApplyConfig. As a workaround, I've made my
plugin return the empty list for RuleNames:
https://github.com/richardTowers/tflint-ruleset-workspaces/blob/master/ruleset.go#L28
Naïvely, it looks like making the ApplyConfig a bit earlier would fix
this.
The tests pass, but I'm not sure if this will have unintended
consequences. Careful review would be much appreciated!