Merge pull request #297 from wata727/fix_panic_is_null_expr

Fix panic when checking whether an expression is null
terraform-linters · May 29, 2019 · d7a28a8 · d7a28a8
2 parents 032d126 + b1b4c89
commit d7a28a8
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/tflint/runner.go b/tflint/runner.go
@@ -366,7 +366,13 @@ func (r *Runner) EnsureNoError(err error, proc func() error) error {
 
 // IsNullExpr check the passed expression is null
 func (r *Runner) IsNullExpr(expr hcl.Expression) bool {
-	val, _ := r.ctx.EvaluateExpr(expr, cty.DynamicPseudoType, nil)
+	if !isEvaluable(expr) {
+		return false
+	}
+	val, diags := r.ctx.EvaluateExpr(expr, cty.DynamicPseudoType, nil)
+	if diags.HasErrors() {
+		return false
+	}
 	return val.IsNull()
 }