-
Notifications
You must be signed in to change notification settings - Fork 349
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #27 from wata727/aws_elasticache_cluster_invalid_p…
…arameter_group add invalid parameter group detector for ElastiCache
- Loading branch information
Showing
7 changed files
with
1,208 additions
and
20 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
detector/aws_elasticache_cluster_invalid_parameter_group.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package detector | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/aws/aws-sdk-go/service/elasticache" | ||
| "github.com/wata727/tflint/issue" | ||
| ) | ||
|
|
||
| type AwsElastiCacheClusterInvalidParameterGroupDetector struct { | ||
| *Detector | ||
| } | ||
|
|
||
| func (d *Detector) CreateAwsElastiCacheClusterInvalidParameterGroupDetector() *AwsElastiCacheClusterInvalidParameterGroupDetector { | ||
| return &AwsElastiCacheClusterInvalidParameterGroupDetector{d} | ||
| } | ||
|
|
||
| func (d *AwsElastiCacheClusterInvalidParameterGroupDetector) Detect(issues *[]*issue.Issue) { | ||
| if !d.isDeepCheck("resource", "aws_elasticache_cluster") { | ||
| return | ||
| } | ||
|
|
||
| validCacheParameterGroups := map[string]bool{} | ||
| if d.ResponseCache.DescribeCacheParameterGroupsOutput == nil { | ||
| resp, err := d.AwsClient.Elasticache.DescribeCacheParameterGroups(&elasticache.DescribeCacheParameterGroupsInput{}) | ||
| if err != nil { | ||
| d.Logger.Error(err) | ||
| d.Error = true | ||
| } | ||
| d.ResponseCache.DescribeCacheParameterGroupsOutput = resp | ||
| } | ||
| for _, parameterGroup := range d.ResponseCache.DescribeCacheParameterGroupsOutput.CacheParameterGroups { | ||
| validCacheParameterGroups[*parameterGroup.CacheParameterGroupName] = true | ||
| } | ||
|
|
||
| for filename, list := range d.ListMap { | ||
| for _, item := range list.Filter("resource", "aws_elasticache_cluster").Items { | ||
| parameterGroupToken, err := hclLiteralToken(item, "parameter_group_name") | ||
| if err != nil { | ||
| d.Logger.Error(err) | ||
| continue | ||
| } | ||
| parameterGroup, err := d.evalToString(parameterGroupToken.Text) | ||
| if err != nil { | ||
| d.Logger.Error(err) | ||
| continue | ||
| } | ||
|
|
||
| if !validCacheParameterGroups[parameterGroup] { | ||
| issue := &issue.Issue{ | ||
| Type: "ERROR", | ||
| Message: fmt.Sprintf("\"%s\" is invalid parameter group name.", parameterGroup), | ||
| Line: parameterGroupToken.Pos.Line, | ||
| File: filename, | ||
| } | ||
| *issues = append(*issues, issue) | ||
| } | ||
| } | ||
| } | ||
| } |
92 changes: 92 additions & 0 deletions
92
detector/aws_elasticache_cluster_invalid_parameter_group_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package detector | ||
|
|
||
| import ( | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "github.com/aws/aws-sdk-go/aws" | ||
| "github.com/aws/aws-sdk-go/service/elasticache" | ||
| "github.com/golang/mock/gomock" | ||
| "github.com/wata727/tflint/awsmock" | ||
| "github.com/wata727/tflint/config" | ||
| "github.com/wata727/tflint/issue" | ||
| ) | ||
|
|
||
| func TestDetectAwsElastiCacheInvalidParameterGroup(t *testing.T) { | ||
| cases := []struct { | ||
| Name string | ||
| Src string | ||
| Response []*elasticache.CacheParameterGroup | ||
| Issues []*issue.Issue | ||
| }{ | ||
| { | ||
| Name: "parameter_group_name is invalid", | ||
| Src: ` | ||
| resource "aws_elasticache_cluster" "redis" { | ||
| parameter_group_name = "app-server" | ||
| }`, | ||
| Response: []*elasticache.CacheParameterGroup{ | ||
| &elasticache.CacheParameterGroup{ | ||
| CacheParameterGroupName: aws.String("app-server1"), | ||
| }, | ||
| &elasticache.CacheParameterGroup{ | ||
| CacheParameterGroupName: aws.String("app-server2"), | ||
| }, | ||
| }, | ||
| Issues: []*issue.Issue{ | ||
| &issue.Issue{ | ||
| Type: "ERROR", | ||
| Message: "\"app-server\" is invalid parameter group name.", | ||
| Line: 3, | ||
| File: "test.tf", | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| Name: "parameter_group_name is valid", | ||
| Src: ` | ||
| resource "aws_elasticache_cluster" "redis" { | ||
| parameter_group_name = "app-server" | ||
| }`, | ||
| Response: []*elasticache.CacheParameterGroup{ | ||
| &elasticache.CacheParameterGroup{ | ||
| CacheParameterGroupName: aws.String("app-server1"), | ||
| }, | ||
| &elasticache.CacheParameterGroup{ | ||
| CacheParameterGroupName: aws.String("app-server2"), | ||
| }, | ||
| &elasticache.CacheParameterGroup{ | ||
| CacheParameterGroupName: aws.String("app-server"), | ||
| }, | ||
| }, | ||
| Issues: []*issue.Issue{}, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range cases { | ||
| c := config.Init() | ||
| c.DeepCheck = true | ||
|
|
||
| awsClient := c.NewAwsClient() | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
| elasticachemock := awsmock.NewMockElastiCacheAPI(ctrl) | ||
| elasticachemock.EXPECT().DescribeCacheParameterGroups(&elasticache.DescribeCacheParameterGroupsInput{}).Return(&elasticache.DescribeCacheParameterGroupsOutput{ | ||
| CacheParameterGroups: tc.Response, | ||
| }, nil) | ||
| awsClient.Elasticache = elasticachemock | ||
|
|
||
| var issues = []*issue.Issue{} | ||
| TestDetectByCreatorName( | ||
| "CreateAwsElastiCacheClusterInvalidParameterGroupDetector", | ||
| tc.Src, | ||
| c, | ||
| awsClient, | ||
| &issues, | ||
| ) | ||
|
|
||
| if !reflect.DeepEqual(issues, tc.Issues) { | ||
| t.Fatalf("Bad: %s\nExpected: %s\n\ntestcase: %s", issues, tc.Issues, tc.Name) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters