Un-export NewLocalRunner
and AddLocalFile
#268
Merged
+9
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussion of terraform-linters/tflint-ruleset-aws#511, I noticed these two function are exported but labeled in their doc comment as "internal use only." I assumed this meant "we use this from other packages, but you shouldn't," which technically should be done in an
internal/
package to prevent external module callers.But turns out that there isn't actually any usage outside the package:
https://github.com/search?q=org%3Aterraform-linters+NewLocalRunner&type=code
https://github.com/search?q=org%3Aterraform-linters+AddLocalFile&type=code
So to prevent any external use, I've un-exported these identifiers. Technically this is a breaking change but it shouldn't actually have any dependents.