Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-export NewLocalRunner and AddLocalFile #268

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

bendrucker
Copy link
Member

In discussion of terraform-linters/tflint-ruleset-aws#511, I noticed these two function are exported but labeled in their doc comment as "internal use only." I assumed this meant "we use this from other packages, but you shouldn't," which technically should be done in an internal/ package to prevent external module callers.

But turns out that there isn't actually any usage outside the package:

https://github.com/search?q=org%3Aterraform-linters+NewLocalRunner&type=code
https://github.com/search?q=org%3Aterraform-linters+AddLocalFile&type=code

So to prevent any external use, I've un-exported these identifiers. Technically this is a breaking change but it shouldn't actually have any dependents.

@bendrucker bendrucker requested a review from wata727 July 6, 2023 16:30
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wata727 wata727 merged commit 19e177f into master Jul 8, 2023
@wata727 wata727 deleted the unexport-local-runner-api branch July 8, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants