Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the bool type as a target value #248

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Mar 26, 2023

This PR changes EvaluateExpr to support the bool type as a target value. Previously the code below would error out as an unsupported target type:

runner.EvaluateExpr(attr.Expr, func (enabled bool) error {
  // Test values
}, nil)

At the same time []bool and map[string]bool are also supported.

@wata727 wata727 merged commit 9fd4538 into master Mar 26, 2023
@wata727 wata727 deleted the add_support_for_bool_target_value branch March 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant