runner: Deprecate EnsureNoError
helper
#236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196
This PR deprecates
runner.EnsureNoError
. Instead, useerrors.Is()
to determine if the error should be ignored:EDIT: The following example fix has been retracted. Please see #246 for more details.
The above is a simple replacement example, but we recommend that you reconsider whether you should ignore the above errors. For example, instead of ignoring null, you may want to raise an error.
See #196 for a discussion on how it came to be deprecated.
EnsureNoError
is not removed at this time, but it will be removed in a future version, so early migration is recommended.