plugin2host: Handle eval errors on the client side #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
changed the title
wata727
commented
Feb 25, 2023
| // ErrUnevaluable is an error when a received expression has unevaluable references. | ||
| // Deprecated: This error is no longer returned since TFLint v0.41. | ||
| ErrUnevaluable = errors.New("") |
There was a problem hiding this comment.
The error is removed in terraform-linters/tflint#1510. The ErrUnknownValue is now returned instead.
wata727
force-pushed
the
handle_errors_in_client
branch
from
316efba to
ae3978a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, errors from evaluating unknown or NULL values were handled on the server side rather than on the client side.
https://github.com/terraform-linters/tflint/blob/v0.45.0/plugin/server.go#L143-L167
But given that
EvaluateExpris an endpoint that returns acty.Value, it's preferable to handle this error on the client side.This PR adds unknown and NULL value handling in
plugin2host.GRPCClient.EvaluateExpr. Below are compatibility notes:For all host versions, conversion of errors on Protocol Buffers may not be necessary once the server side no longer returns errors, but is currently retained for compatibility reasons.