host2plugin: Allow plugins to set host version constraints #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
version_constraint
branch
from
aa0b7cc to
bece7ac
Compare
wata727
force-pushed
the
version_constraint
branch
from
bece7ac to
4a99577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189
This PR adds a new
GetVersionConstraintmethod to the plugin server, allowing you to set version constraints of TFLint the plugin should work with.The host process calls this endpoint to check if own version satisfies the constraints. If the constraint is not met, the process will be exited with an error before starting the inspection. This avoids confusing users with incorrect behavior in TFLint where new features are not supported.
If no version constraint is set, or if this endpoint is not supported in plugins, TFLint will ignore constraint checking. This behavior is the default, and plugin developers are encouraged not to set constraints unless there is a reason to do so.