Add tflint.ErrSensitive #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also terraform-linters/tflint#1457
This PR add a new error type,
tflint.ErrSensitive. This error occurs when the result of an expression evaluated byEvaluateExprcontains sensitive values.Whether or not you want to inspect sensitive values is debatable. But in many cases, it's more valuable to prevent unintentional disclosure, such as accidentally inspecting it as a string and printing it to the console.
Based on this determination, TFLint returns
tflint.ErrSensitiveif it contains sensitive values. The SDK treats the error to be ignored withEnsureNoErrorsin the same way as withErrUnevaluable.Compatibility note: If an
ErrSensitiveoccurs in an older SDK version, this error will not be ignored, just treated as an error. However, this is almost identical to the "value has marks, so it cannot be serialized" error.