Optimize GetModuleContent performance #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two optimizations for GetModuleContent API.
One is a hint phrase as an option. If you are extracting content based on a schema, you should extract all resources, even if you are inspecting for a particular resource. This is obviously inefficient. The hint phrase can be used to determine whether the resource exists at an early stage.
The other is to change the return value of GetFiles. The server returns
map[string]*hcl.File, just like the client. This is inefficient if you have a large number of files, as it requires a step to convert to bytes. For this reason, this PR changes the server to returnmap[string][]byte.