Skip to content

Commit

Permalink
Pass only type to EvalExpr when passed detailed types (#107)
Browse files Browse the repository at this point in the history
  • Loading branch information
wata727 authored Mar 20, 2021
1 parent 0849939 commit ae6749e
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tflint/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,10 @@ func (c *Client) EvaluateExpr(expr hcl.Expression, ret interface{}, wantType *ct
}

var response EvalExprResponse
req := EvalExprRequest{Ret: ret, Type: *wantType}
req := EvalExprRequest{Type: *wantType}
if req.Type == (cty.Type{}) {
req.Ret = ret
}
req.Expr, req.ExprRange = encodeExpr(file.Bytes, expr)
if err := c.rpcClient.Call("Plugin.EvalExpr", req, &response); err != nil {
return err
Expand Down Expand Up @@ -285,7 +288,10 @@ func (c *Client) EvaluateExprOnRootCtx(expr hcl.Expression, ret interface{}, wan
}

var response EvalExprResponse
req := EvalExprRequest{Ret: ret, Type: *wantType}
req := EvalExprRequest{Type: *wantType}
if req.Type == (cty.Type{}) {
req.Ret = ret
}
req.Expr, req.ExprRange = encodeExpr(file.Bytes, expr)
if err := c.rpcClient.Call("Plugin.EvalExprOnRootCtx", req, &response); err != nil {
return err
Expand Down

0 comments on commit ae6749e

Please sign in to comment.